Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add breadcrumbs to pages without them #3168

Merged
merged 16 commits into from
May 13, 2024
Merged

Add breadcrumbs to pages without them #3168

merged 16 commits into from
May 13, 2024

Conversation

MylesJarvis
Copy link
Contributor

@MylesJarvis MylesJarvis commented Apr 26, 2024 •
edited
Loading

Trello card

https://trello.com/c/gapHzCUD

Context

  • Some pages lack breadcrumbs
  • Some pages lack backlinks

Changes proposed in this pull request

  • Add breadcrumbs to the toggle profile page
  • Add breadcrumbs to choose how dates are displayed page
  • Add backlinks to contact us/request access to another organisation/close placement dates page

Guidance to review

  • Do breadcrumbs render on the profile on/off page?
  • Do breadcrumbs render on the 'choose how dates are displayed' page?
  • Do the breadcrumbs link to where you expect?
  • Are backlinks appropriate in the other locations?
  • Should we use breadcrumbs in the close placement date page?

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Apr 26, 2024
@MylesJarvis MylesJarvis changed the title Add breadcrumbs to turn profile on/off Add breadcrumbs to pages without them Apr 26, 2024
@MylesJarvis
Copy link
Contributor Author

MylesJarvis commented Apr 29, 2024 •
edited
Loading

Closing a placement date

Before

image

After

Option 1 - now replaced
image

Option 2 - currently deployed in preview app

image

Questions for review: Does this also require a 'return to dashboard' link? Is the back button the appropriate module here, or do we think a fully featured breadcrumb is a better option?

@MylesJarvis
Copy link
Contributor Author

Turn profile on/off

Before

image

After

image

@MylesJarvis
Copy link
Contributor Author

Choose how dates are displayed

Before

image

After

image

@MylesJarvis
Copy link
Contributor Author

Contact us page

Before

image

After

image

@MylesJarvis
Copy link
Contributor Author

Request access to another organisation

Before

image

After

image

@MylesJarvis MylesJarvis marked this pull request as ready for review April 30, 2024 09:10
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Review app deployed to https://get-school-experience-review-pr-3168.test.teacherservices.cloud
✅ DfE sign in route obtained: https://get-school-experience-review-pr-4.test.teacherservices.cloud

gemmadallmandfe
gemmadallmandfe approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from a front-end perspective

Needs a tech review before merging

martyn-w
martyn-w approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@martyn-w martyn-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@MylesJarvis MylesJarvis merged commit 10d8ab3 into master May 13, 2024
15 checks passed
@MylesJarvis MylesJarvis deleted the add-breadcrumbs branch May 13, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemmadallmandfe gemmadallmandfe gemmadallmandfe approved these changes

@martyn-w martyn-w martyn-w approved these changes

Assignees
No one assigned
Labels
Review ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MylesJarvis @martyn-w @gemmadallmandfe